Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinesisvideoarchivedmedia.ListFragments is missing a paginator #1572

Closed
3 tasks done
keep-cloud-tr opened this issue Jan 26, 2022 · 3 comments
Closed
3 tasks done

kinesisvideoarchivedmedia.ListFragments is missing a paginator #1572

keep-cloud-tr opened this issue Jan 26, 2022 · 3 comments
Labels
feature-request A feature should be added or improved. l Effort estimation: large p3 This is a minor priority issue

Comments

@keep-cloud-tr
Copy link

keep-cloud-tr commented Jan 26, 2022

Documentation

Describe the bug

There is no paginator for kinesisvideoarchivedmedia ListFragments. Fragments can easily exceed the default page size, so this is needed.

It is present in the v1 sdk: https://github.com/aws/aws-sdk-go/blob/895cfb31afb235ab5461432d181680152cafe67d/service/kinesisvideoarchivedmedia/api.go#L934

It was also present in the v2 sdk at one time, but was removed for some reason:

func NewListFragmentsPaginator(client ListFragmentsAPIClient, params *ListFragmentsInput, optFns ...func(*ListFragmentsPaginatorOptions)) *ListFragmentsPaginator {

Similar to: aws/aws-sdk#257

Expected behavior

kinesisvideoarchivedmedia.NewListFragmentsPaginator to be defined

Current behavior

kinesisvideoarchivedmedia.NewListFragmentsPaginator is not defined

Steps to Reproduce

go doc github.com/aws/aws-sdk-go-v2/service/kinesisvideoarchivedmedia | grep -i fragment | grep -i pagi

Possible Solution

Re-implement kinesisvideoarchivedmedia.NewListFragmentsPaginator.

AWS Go SDK version used

github.com/aws/aws-sdk-go-v2 v1.13.0

Compiler and Version used

go version go1.17.6 linux/amd64

Operating System and version

Linux

@keep-cloud-tr keep-cloud-tr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 26, 2022
@vudh1 vudh1 self-assigned this Mar 9, 2022
@vudh1 vudh1 added feature-request A feature should be added or improved. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 25, 2022
@vudh1 vudh1 removed their assignment Aug 25, 2022
@keep-cloud-tr
Copy link
Author

Would it be sufficient to just add a paginated trait to the smithy model?

diff --git a/codegen/sdk-codegen/aws-models/kinesis-video-archived-media.json b/codegen/sdk-codegen/aws-models/kinesis-video-archived-media.json
index 7c144a7b8a..5c663e41a2 100644
--- a/codegen/sdk-codegen/aws-models/kinesis-video-archived-media.json
+++ b/codegen/sdk-codegen/aws-models/kinesis-video-archived-media.json
@@ -1241,6 +1241,12 @@
                     "method": "POST",
                     "uri": "/listFragments",
                     "code": 200
+                },
+                "smithy.api#paginated": {
+                    "inputToken": "NextToken",
+                    "outputToken": "NextToken",
+                    "items": "FragmentList",
+                    "pageSize": "MaxResults"
                 }
             }
         },

@RanVaknin RanVaknin added p3 This is a minor priority issue l Effort estimation: large labels Nov 10, 2022
@lucix-aws
Copy link
Contributor

The described paginator is present today, I'm assuming this was fixed upstream in the model. Closing.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. l Effort estimation: large p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

4 participants