Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monorepo devDep on "@aws/pdk@^0" prevents consumer from defining version #586

Closed
JeremyJonas opened this issue Sep 28, 2023 · 1 comment
Closed
Assignees

Comments

@JeremyJonas
Copy link
Contributor

By having devDep on @aws/pdk@^0 pinned to ^0 it overrides any consumer devDep on pdk set in options. Which is preventing pulling the latest in consuming repo.

https://github.com/aws/aws-pdk/blob/1a542c19973e3b999be496636051fe5e9e586323/packages/monorepo/src/projects/typescript/monorepo-ts.ts#L277C31-L277C44

Work Around

Have to override the devDep after monorepo constructor

super(...)

this.addDevDeps("@aws/pdk@^0.22.9");

Proposal

We should be checking to see if "@aws/pdk" is already added to the deps, and only add it if missing

@agdimech
Copy link
Contributor

Resolved in #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants