-
|
I didn't check up on this repo and I just saw that Same happens if I use the It does say that |
Beta Was this translation helpful? Give feedback.
Replies: 6 comments 21 replies
-
|
It is published! :) You will need to add a dependency on the new package though as well as upgrading the other packages :) eg if you're using the const monorepo = new NxMonorepoProject({
name: "my-project",
defaultReleaseBranch: "main",
devDeps: ["aws-prototyping-sdk", "@aws-prototyping-sdk/type-safe-api"],
});Also note that because it's a dependency that the
Hope that helps! :) |
Beta Was this translation helpful? Give feedback.
-
|
Ugh, can't believe I missed that! Thank you :D |
Beta Was this translation helpful? Give feedback.
-
|
No worries!! Hope the migration goes smoothly! Let me know if you have any issues :) |
Beta Was this translation helpful? Give feedback.
-
|
@cogwirrel the migration so far is going good. I have a question tho about where the code of the Lambda handlers/routers should go: Should I create a |
Beta Was this translation helpful? Give feedback.
-
|
Nice! What I'd recommend is creating a separate infrastructure project (eg with It's best not to add code to Hope that helps! I notice the quick start guide isn't very clear where things should live so I'll look at updating that soon! :) |
Beta Was this translation helpful? Give feedback.
-
|
I'll make a new TypeScriptProject for it!
|
Beta Was this translation helpful? Give feedback.
-
|
I finished the migration, some notes about the process:
Not related to PDK:
All in all, looking good! Thank you for all the help and I like PDK a lot :D. |
Beta Was this translation helpful? Give feedback.
-
|
Awesome glad you made it! 😄 Ahh what was the issue with Ah cool, that works! In case it's helpful, something like this for a standalone TypeScriptProject for lambdas might do the trick: const lambdas = new TypeScriptProject({
parent: monorepo,
outdir: 'packages/lambdas',
...
deps: [
api.runtime.typescript!.package.packageName,
],
devDeps: [
'esbuild',
],
});
// Build the lambda dist
lambdas.packageTask.reset('mkdir -p lambdadist && esbuild src/index.ts --bundle --platform=node --outfile=lambdadist/index.js');
lambdas.gitignore.addPatterns("lambdadist");Then in your infrastructure, (assuming you export a function for every api handler, eg const fn = new Function(this, 'Lambda', {
handler: "index.sayHello",
runtime: Runtime.NODEJS_18_X,
code: Code.fromAsset('path/to/lambdadist'),
});Hope that makes sense! :) |
Beta Was this translation helpful? Give feedback.
-
I couldn't reproduce it! So I didn't make an issue. Deleting the Thank you! |
Beta Was this translation helpful? Give feedback.
-
|
Ahh gotcha! I've experienced some funkiness with switching from Great to hear! 😄 |
Beta Was this translation helpful? Give feedback.
-
|
I've been trying to get everything over using Steps to reproducenpx projen new --from aws-prototyping-sdk nx-monorepo && pnpm installError message: So do I need to do |
Beta Was this translation helpful? Give feedback.
-
|
Ok it should be there in 0.17.5! https://github.com/aws/aws-prototyping-sdk/releases/tag/v0.17.5 |
Beta Was this translation helpful? Give feedback.
-
|
I've switched over to One of my subprojects has the following devdeps in its The I've tried wiping all the node_modules and running |
Beta Was this translation helpful? Give feedback.
-
|
Hmmm how do you define your script for vite dev in your A potential workaround might be to change your task from |
Beta Was this translation helpful? Give feedback.
-
|
It's the former: Even I'll try to get a repro going :P. |
Beta Was this translation helpful? Give feedback.
-
|
Very odd! Nice that'd be great if you could raise an issue with a minimal example :) |
Beta Was this translation helpful? Give feedback.
-
|
Also (hopefully my last question :P), how do I change the name of the |
Beta Was this translation helpful? Give feedback.
-
|
Haha no shame in lots of questions! The more questions (and hopefully answers!) the more it helps other users too! 😄 You can change the name of the API client by using tags on your operations, eg: @tags(["Foo"])
operation DoSomething {
...
}Will result in the I'll usually use the same first tag for all my operations to collate them in the same client class, but then add extra tags to group things nicely in the generated |
Beta Was this translation helpful? Give feedback.
-
|
Crystal clear! Thank you for all the help, I'm learning Smithy, PDK, projen as I go :P, so this all very helpful (also sorry I noticed the docs mention this as well). |
Beta Was this translation helpful? Give feedback.
-
I had 30 minutes of bliss programming, when I did an This error seems eerily similiar to this: aws/aws-cdk#3416 so I don't think it's a PDK issue, but can I somehow pin/resolve versions for |
Beta Was this translation helpful? Give feedback.
-
|
Hey! Ah yeah that happens fairly regularly when upgrading cdk/constructs versions! The best option is usually to add package resolutions. You can do something like: monorepo.package.addPackageResolutions("constructs@xxx", "aws-cdk-lib@yyy");That should hopefully pin your constructs/cdk versions across all packages in the workspace :) |
Beta Was this translation helpful? Give feedback.
-
|
Sweet, now I can get back to blissful programming! Thank you :D |
Beta Was this translation helpful? Give feedback.
It is published! :) You will need to add a dependency on the new package though as well as upgrading the other packages :) eg if you're using the
nx-monorepo:Also note that because it's a dependency that the
.projenrc.tsmakes use of, you need to do 2 passes with projen:npx projento add the dependencyTypeSafeApiProjectfrom@aws-prototyping-sdk/type-safe-apiin your.projenrc.ts, configure it, andnpx projenagainHope th…