-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ConnectEvent queue definition #459
Merged
andclt
merged 1 commit into
aws:events-v4-serialization-v2
from
offthewall123:update_connectEvent_queue
Nov 9, 2023
Merged
update ConnectEvent queue definition #459
andclt
merged 1 commit into
aws:events-v4-serialization-v2
from
offthewall123:update_connectEvent_queue
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the change. Could you update the Connect serialization test please. |
offthewall123
force-pushed
the
update_connectEvent_queue
branch
from
October 31, 2023 09:04
1e87663
to
8dfccf1
Compare
msailes
reviewed
Oct 31, 2023
...bda-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/ConnectEvent.java
Outdated
Show resolved
Hide resolved
offthewall123
force-pushed
the
update_connectEvent_queue
branch
from
October 31, 2023 09:32
8dfccf1
to
c75b8b5
Compare
msailes
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
andclt
reviewed
Oct 31, 2023
...bda-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/ConnectEvent.java
Outdated
Show resolved
Hide resolved
andclt
reviewed
Oct 31, 2023
...bda-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/ConnectEvent.java
Outdated
Show resolved
Hide resolved
offthewall123
force-pushed
the
update_connectEvent_queue
branch
from
November 1, 2023 02:04
c75b8b5
to
a7682f8
Compare
andclt
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
smirnoal
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Update ConnectEvent Queue definition. According to Amazon Connect latest doc: https://docs.aws.amazon.com/connect/latest/adminguide/connect-lambda-functions.html#function-contact-flow, Queue is an Object. Current type definition is String, which causes parsing error
Cannot deserialize value of type `java.lang.String` from Object value (token `JsonToken.START_OBJECT`) at [Source: (ByteArrayInputStream); line: 1, column: 580] (through reference chain: com.amazonaws.services.lambda.runtime.events.ConnectEvent["Details"]->com.amazonaws.services.lambda.runtime.events.ConnectEvent$Details["ContactData"]->com.amazonaws.services.lambda.runtime.events.ConnectEvent$ContactData["Queue"])
*Target (OCI, Managed Runtime, both):*Managed Runtime
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.