Deploy Tool Hangs Indefinitely When Docker Hangs

[ashovlin]

Describe the bug

I'm trying to deploy a new application, but the deploy tool is hanging indefinitely here:

Choose deployment option (recommended default: 1)
3

Name the Cloud Application to deploy your project to
--------------------------------------------------------------------------------
Enter the name of the new CloudFormationStack stack (default WebAppWithDockerFile):

Expected Behavior

Deployment to proceed

Current Behavior

Upon investigation, the docker info we're running is hanging indefinitely as well

aws-dotnet-deploy/src/AWS.Deploy.Orchestration/SystemCapabilityEvaluator.cs

Lines 51 to 61 in 52f2ff4

	await _commandLineWrapper.Run(
	command,
	streamOutputToInteractiveService: false,
	onComplete: proc =>
	{
	processExitCode = proc.ExitCode;
	containerType = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ?
	proc.StandardOut?.TrimEnd('\n') ??
	throw new DockerInfoException(DeployToolErrorCode.FailedToCheckDockerInfo, "Failed to check if Docker is running in Windows or Linux container mode.") :
	"linux";
	});

Reproduction Steps

Unsure why my Docker installation is stuck, it seems like Docker can hang for multiple reasons: docker/cli#3433

It resolved itself once I did a factory reset of Docker Desktop.

Possible Solution

The deploy tool should be more resilient (set timeout on the child processes?) and display a helpful error message. For both docker info and node --version, I'd think we expect these to complete within a couple seconds.

Additional Information/Context

No response

Version used

1.14.6

Operating System and version

Windows 10

[ashishdhingra]

Needs review. Makes sense to have a timeout (might be configurable via parameter) for the child processes to return.

[ashovlin]

Fixed in https://github.com/aws/aws-dotnet-deploy/releases/tag/1.21.13 via #837, we now timeout at a minute for the Docker and Node checks.

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.