Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Replace jackson databind with jackson-jr #1479

Closed
jeromevdl opened this issue Oct 16, 2023 · 3 comments
Closed

RFC: Replace jackson databind with jackson-jr #1479

jeromevdl opened this issue Oct 16, 2023 · 3 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request maven RFC v2 Version 2
Milestone

Comments

@jeromevdl
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Reduce the size of the final package size.

Describe the solution you'd like
Use jackon-jr instead of jackson databind if possible.
In particular, make sure the other dependencies we have (thinking about jmespath for example) don't pull jackson-databind. Otherwise we'll have a bigger jar in the end (databind + jackson-jr)

Describe alternatives you've considered
N/A

@jeromevdl
Copy link
Contributor Author

See #761 and go further...

@jeromevdl jeromevdl added enhancement New feature or request dependencies Pull requests that update a dependency file maven v2 Version 2 and removed triage labels Oct 16, 2023
@jeromevdl
Copy link
Contributor Author

jeromevdl commented Oct 23, 2023

I've implemented a jackson-jr version of jmespath, available in v0.6.0

@jeromevdl jeromevdl moved this from Triage to Backlog in Powertools for AWS Lambda (Java) Oct 30, 2023
@jeromevdl jeromevdl added the RFC label Oct 30, 2023
@jeromevdl jeromevdl changed the title Replace jackson databind with jackson-jr RFC: Replace jackson databind with jackson-jr Oct 30, 2023
@jeromevdl jeromevdl self-assigned this Oct 30, 2023
@jeromevdl
Copy link
Contributor Author

jeromevdl commented Nov 22, 2023

Second time I go through this one and break my teeth on it. Too many dependencies are leveraging jackson databind:

  • json-schema-validator (in validation module)
  • X-Ray (and more broadly the aws-sdk-core used in tracing, parameters, idempotency, ...)
  • payloadoffloading (for the large message module)
  • embedded-metrics (in metrics module)
  • jmespath (this one I managed to get a jackson-jr version, see above)

Almost every module has it as a dependency in a way... Closing as can't resolve

@scottgerring scottgerring added this to the v2 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request maven RFC v2 Version 2
Projects
Status: Backlog
Development

No branches or pull requests

2 participants