Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup poms and reduce warning noise #1535

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

jdoherty
Copy link
Contributor

@jdoherty jdoherty commented Dec 4, 2023

Issue #: #1463

Description of changes:

Removed duplicated information from child poms that was present in parent pom.
Added version of plugin and optimised imports to reduce warning noises

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdoherty jdoherty changed the base branch from main to v2 December 4, 2023 14:52
Copy link

github-actions bot commented Dec 4, 2023

💾 Artifacts Size Report

Module Version Size (KB)
powertools-common 2.0.0-SNAPSHOT 9.59
powertools-serialization 2.0.0-SNAPSHOT 17.69
powertools-logging 2.0.0-SNAPSHOT 20.73
powertools-logging-log4j 2.0.0-SNAPSHOT 21.78
powertools-logging-logback 2.0.0-SNAPSHOT 20.18
powertools-tracing 2.0.0-SNAPSHOT 13.20
powertools-metrics 2.0.0-SNAPSHOT 14.05
powertools-parameters 2.0.0-SNAPSHOT 17.46
powertools-validation 2.0.0-SNAPSHOT 19.96
powertools-cloudformation 2.0.0-SNAPSHOT 16.60
powertools-idempotency 2.0.0-SNAPSHOT 43.22
powertools-large-messages 2.0.0-SNAPSHOT 17.44
powertools-batch 2.0.0-SNAPSHOT 16.89
powertools-parameters-ssm 2.0.0-SNAPSHOT 10.62
powertools-parameters-secrets 2.0.0-SNAPSHOT 9.84
powertools-parameters-dynamodb 2.0.0-SNAPSHOT 11.88
powertools-parameters-appconfig 2.0.0-SNAPSHOT 11.48

@jdoherty jdoherty linked an issue Dec 4, 2023 that may be closed by this pull request
2 tasks
examples/pom.xml Show resolved Hide resolved
powertools-cloudformation/pom.xml Show resolved Hide resolved
powertools-e2e-tests/pom.xml Outdated Show resolved Hide resolved
@jdoherty jdoherty force-pushed the feature-pom-cleanup branch from 865f36b to 4505c13 Compare December 13, 2023 20:44
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2@b139a96). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1535   +/-   ##
=====================================
  Coverage      ?   87.21%           
  Complexity    ?      530           
=====================================
  Files         ?       61           
  Lines         ?     1854           
  Branches      ?      230           
=====================================
  Hits          ?     1617           
  Misses        ?      163           
  Partials      ?       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @jdoherty !

@scottgerring scottgerring merged commit 516db4e into v2 Dec 14, 2023
14 checks passed
@scottgerring scottgerring deleted the feature-pom-cleanup branch December 14, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Clean up POMs
3 participants