Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance(v2): Update aspectj dependency to current version #1401

Open
1 of 2 tasks
roamingthings opened this issue Aug 29, 2023 · 0 comments · Fixed by #1408
Open
1 of 2 tasks

Maintenance(v2): Update aspectj dependency to current version #1401

roamingthings opened this issue Aug 29, 2023 · 0 comments · Fixed by #1408
Assignees
Labels
maintenance status/staged-major-release This change will go with the next major release v2 Version 2
Milestone

Comments

@roamingthings
Copy link
Contributor

Summary

Update the aspectj dependency (currently 1.9.20) for Java 17 compativility.

Why is this needed?

We have a project with multiple Gradle modules and are using the io.freefair.aspectj.post-compile-weaving plugin as described in the documentation. This setup will pull in version 1.9.7 of the aspectjrt dependency that is referenced by the Powertools library and overwrite/ignore the version that is usually referenced by the aspectjrt plugin. Unfortunately version 1.9.7 is not compatible with Java 17 leading to an error when building the project:

[error] target level should be in '1.1'...'1.8','9'...'16' (or '5.0'..'16.0') or cldc1.1: 17

This issue has been addressed by the AspectJ project some times ago.

To use Java 17 we have to manually add aspectjrt as dependency in the current version. This means additional maintenance since we have to manually update this dependency according to the version used by the plugin.

Which area does this relate to?

No response

Solution

Either update aspectjrt to the current version or no longer propagate aspectj as a transient dependency. In the latter case I'm not sure if projects would still compile, when you don't use the plugin in you project. So 'removing' the dependency would make more sense in the next major release of the Powertools.

I would be happy to provide a PR, also it would require some testing with Maven, which I don't use that often.

Acknowledgment

@jeromevdl jeromevdl self-assigned this Aug 30, 2023
@scottgerring scottgerring linked a pull request Aug 30, 2023 that will close this issue
6 tasks
@scottgerring scottgerring moved this from Triage to Working on it in Powertools for AWS Lambda (Java) Aug 31, 2023
@jeromevdl jeromevdl moved this from Working on it to Coming soon in Powertools for AWS Lambda (Java) Sep 11, 2023
@jeromevdl jeromevdl added status/staged-next-release status/staged-major-release This change will go with the next major release and removed status/staged-next-release labels Sep 11, 2023
@jeromevdl jeromevdl changed the title Maintenance: Update aspectj dependency to current version Maintenance(v2): Update aspectj dependency to current version Nov 15, 2023
@jeromevdl jeromevdl added the v2 Version 2 label Nov 15, 2023
@scottgerring scottgerring added this to the v2 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance status/staged-major-release This change will go with the next major release v2 Version 2
Projects
Status: Coming soon
Development

Successfully merging a pull request may close this issue.

3 participants