Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sonar issues #1313

Closed
wants to merge 22 commits into from
Closed

fix: sonar issues #1313

wants to merge 22 commits into from

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available:

Description of changes:

Fixed a bunch of findings in sonar

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 72.22% and project coverage change: +0.29% 🎉

Comparison is base (530968f) 79.65% compared to head (2597c3c) 79.95%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1313      +/-   ##
============================================
+ Coverage     79.65%   79.95%   +0.29%     
  Complexity      639      639              
============================================
  Files            73       71       -2     
  Lines          2345     2335      -10     
  Branches        253      253              
============================================
- Hits           1868     1867       -1     
+ Misses          397      388       -9     
  Partials         80       80
Files Changed Coverage Δ
...lambda/powertools/core/internal/SystemWrapper.java 100.00% <ø> (ø)
...ls/logging/internal/AbstractJacksonLayoutCopy.java 0.00% <ø> (ø)
.../powertools/logging/internal/LambdaJsonLayout.java 0.00% <0.00%> (ø)
...zon/lambda/powertools/parameters/ParamManager.java 79.24% <ø> (+1.46%) ⬆️
...lambda/powertools/utilities/EventDeserializer.java 100.00% <ø> (+0.90%) ⬆️
...oftware/amazon/lambda/powertools/sqs/SqsUtils.java 80.82% <ø> (+1.09%) ⬆️
...bda/powertools/tracing/internal/SystemWrapper.java 100.00% <ø> (+50.00%) ⬆️
...ertools/cloudformation/CloudFormationResponse.java 87.32% <11.11%> (+2.18%) ⬆️
...mpotency/persistence/DynamoDBPersistenceStore.java 90.07% <50.00%> (ø)
...tools/idempotency/internal/IdempotencyHandler.java 66.12% <72.72%> (ø)
... and 6 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeromevdl
Copy link
Contributor Author

It's not finished @kozub ... If you want to do a bit, feel free ;) it's not the most exciting task so I just started. but we certainly don't need to fix everything, we can sort out what is important or not

@kozub
Copy link
Contributor

kozub commented Jul 26, 2023

It's not finished @kozub ... If you want to do a bit, feel free ;) it's not the most exciting task so I just started. but we certainly don't need to fix everything, we can sort out what is important or not

Didn't noticed that it's a draft. I should have a coffee before reviewing it ;-)
will try to help a bit with it 

@kozub kozub self-requested a review July 26, 2023 11:31
kozub
kozub reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@kozub kozub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far ;-)

@kozub kozub self-requested a review July 26, 2023 11:32
@scottgerring scottgerring linked an issue Aug 24, 2023 that may be closed by this pull request
Maintenance: Address sonar lints #1395
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozub kozub Awaiting requested review from kozub

Assignees

@jeromevdl jeromevdl

Labels
size/L
Projects
Powertools for AWS Lambda (Java)
Status: Working on it
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: Address sonar lints
4 participants
@jeromevdl @codecov-commenter @kozub @scottgerring