Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS::ElastiCache::UserGroup] - [BUG] - Engine cannot be set to valkey #2199

Open
mazyu36 opened this issue Nov 25, 2024 · 3 comments
Open
Labels

Comments

@mazyu36
Copy link

mazyu36 commented Nov 25, 2024

Name of the resource

AWS::ElastiCache::UserGroup

Resource Name

No response

Issue Description

In the docs description, Engine supported values are valkey and redis.

But valkey does not exist in allowed values.

I tried to deploy with engine valkey, but encountered an error.

CREATE_FAILED        | AWS::ElastiCache::UserGroup           | UserGroup (UserGroupC755C9ED) Properties validation failed for resource UserGroupC755C9ED with message:
[#/Engine: valkey is not a valid enum value]

Expected Behavior

Can deploy an UserGroup with engine valkey.

Observed Behavior

Cannot deploy an UserGroup with engine valkey.

Test Cases

Set Engine to valkey in UserGroup.

Other Details

No response

@mazyu36 mazyu36 added the bug label Nov 25, 2024
@r-heimann
Copy link

According to https://docs.aws.amazon.com/AmazonElastiCache/latest/dg/Clusters.RBAC.html

Note
When using RBAC with Valkey clusters, you will still need to assign users and user groups the engine “redis”.

Doesn't really make sense why you need to choose "redis", but i don't believe this is a bug.

@mazyu36
Copy link
Author

mazyu36 commented Nov 27, 2024

Thank you for the comment.
Previously, we could only set redis as a property, but on November 21, 2024,valkey became configurable.

Ref: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/ReleaseHistory.html

It is now actually settable for User.

For UserGroup, the description and allowed values do not match, so I have raised this issue.​​​​​​​​​​​​​​​​

@r-heimann
Copy link

Got it, it seems like the ElastiCache API already allows the value valkey: https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_CreateUserGroup.html

Engine: Sets the engine listed in a user group. The options are valkey or redis.
Type: String
Pattern: [a-zA-Z]*
Required: Yes

But CloudFormation does not offer it yet :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants