Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract tests: catch primary identifier change during update #361

Closed
tobywf opened this issue Dec 2, 2019 · 1 comment · Fixed by #482
Closed

Contract tests: catch primary identifier change during update #361

tobywf opened this issue Dec 2, 2019 · 1 comment · Fixed by #482

Comments

@tobywf
Copy link
Contributor

tobywf commented Dec 2, 2019

I don't think primary identifiers/physical resource IDs can be changed during UPDATE, so we should test for this. Maybe additional validation can be added to the resource schema validation to ensure the primary identifier is marked create only.
@ammokhov ammokhov mentioned this issue May 22, 2020
Merged
@rjlohan
Copy link
Contributor

rjlohan commented Jul 8, 2020

Definitely primaryIdentifier should require the same setting in createOnlyProperties as it can not be changed on Update.

readonlyProperties is an additional semantic setting which would be present if the primaryIdentifier is not user-defined.

@ammokhov ammokhov mentioned this issue Jul 8, 2020
Merged
@ammokhov ammokhov linked a pull request Jul 8, 2020 that will close this issue
added primary id validation #482
Merged
@ammokhov ammokhov mentioned this issue Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added primary id validation ammokhov/cloudformation-cli
2 participants
@tobywf @rjlohan