Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Application Insights Tier and Log values aren't accepting any valid values #2271

Closed
aelcinyc opened this issue May 18, 2022 · 1 comment · Fixed by #2272
Closed

AWS Application Insights Tier and Log values aren't accepting any valid values #2271

aelcinyc opened this issue May 18, 2022 · 1 comment · Fixed by #2272

Comments

@aelcinyc
Copy link

aelcinyc commented May 18, 2022

cfn-lint version: v0.58.4

Description of issue.
AWS::ApplicationInsights::Application.ComponentMonitoringSetting.Tier
AWS::ApplicationInsights::Application.Log.LogType
These 2 property types are not accepting any valid values defined within regex.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-applicationinsights-application-log.html#cfn-applicationinsights-application-log-logtype

We see the regex details provided here
https://github.com/aws-cloudformation/cfn-lint/tree/main/src/cfnlint/data/CloudSpecs
which don''t reflect most recent source value defined here
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html

Please provide as much information as possible:

Sample Template

  myappinsights: 
    Type: AWS::ApplicationInsights::Application
    Properties:
      ResourceGroupName: !Ref CreateResourceGroup
      CWEMonitorEnabled: true
      OpsCenterEnabled: true
      OpsItemSNSTopicArn: !Ref SNSTopic
      AutoConfigurationEnabled: true
      ComponentMonitoringSettings:
      - ComponentName: !Ref SqlFSxFCIName
        Tier: 'SQL_SERVER'
        ComponentConfigurationMode: DEFAULT_WITH_OVERWRITE
        DefaultOverwriteComponentConfiguration:
          SubComponentTypeConfigurations:
            - SubComponentType: 'AWS::EC2::Instance'
              SubComponentConfigurationDetails:
                Logs:
                  - LogGroupName: !Sub 'SQL_SERVER-${ResourceGrpName}'
                    LogType: 'SQL_SERVER'
                    LogPath: >-
                      C:\Program Files\Microsoft SQL
                      Server\MSSQL**.MSSQLSERVER\MSSQL\Log\ERRORLOG
@kddejong
Copy link
Contributor

Related to this issue. We will have to fix our regex testing so that we aren't allowing these types into the spec.

aws-cloudformation/aws-cloudformation-resource-providers-applicationinsights#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants