-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocompletion / links on hover for Registry types #199
Comments
debating JSON patch for the implementation: [
{
"op":"add",
"path":"/definitions/RESOURCE_TYPE",
"value":{}
},
{
"op":"add",
"path":"/definitions/resources/patternProperties/^[a-zA-Z0-9]{1,255}$/oneOf/-",
"value":{
"$ref" : "#/definitions/RESOURCE_TYPE"
}
}
] full definition:[
{
"op":"add",
"path":"/definitions/RESOURCE_TYPE",
"value":{
"type":"object",
"properties":{
"DependsOn":{
"type":[
"string",
"array"
],
"items":{
"type":"string"
}
},
"Metadata":{
"description":"https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-metadata.html",
"type":"object"
},
"DeletionPolicy":{
"description":"https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-deletionpolicy.html",
"type":"string",
"enum":[
"Delete",
"Retain",
"Snapshot"
]
},
"UpdateReplacePolicy":{
"description":"https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-updatereplacepolicy.html",
"type":"string",
"enum":[
"Delete",
"Retain",
"Snapshot"
]
},
"CreationPolicy":{
"description":"https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-creationpolicy.html",
"type":"object"
},
"UpdatePolicy":{
"description":"https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-updatepolicy.html",
"type":"object"
},
"Type":{
"type":"string",
"enum":[
"RESOURCE_TYPE"
]
},
"Properties": RESOURCE_SCHEMA
},
"required":[
# "Properties", # required only if some properties are required
"Type"
],
"additionalProperties":false
}
},
{
"op":"add",
"path":"/definitions/resources/patternProperties/^[a-zA-Z0-9]{1,255}$/oneOf/-",
"value":{
"$ref":"#/definitions/RESOURCE_TYPE"
}
}
] |
7 tasks
We have this in now. There may be ways to improve it but those are future issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Could ideally re-use schemas already passed in for linting itself:
aws-cloudformation/cfn-lint#1732
schema/all-spec.json
just needs anotherdefinition
per schema:attributes snippet:
and
resources
patternProperties
needs to reference thatdefinition
:although VSCode may need to be restarted between schema patches? Only way I've been able to get it to pick up edits so far.. but maybe just the extension's client server could be restarted or something? @kddejong would know more than me on that side of things :)
The text was updated successfully, but these errors were encountered: