Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::LanguageExtensions not supporting RetainExceptOnCreate #139

Open
ZalmnS opened this issue Aug 16, 2023 · 2 comments
Open

AWS::LanguageExtensions not supporting RetainExceptOnCreate #139

ZalmnS opened this issue Aug 16, 2023 · 2 comments

Comments

@ZalmnS
Copy link

ZalmnS commented Aug 16, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about the bug

Recently, CloudFormation released support for RetainExceptOnCreate as a new value for the DeletionPolicy Attribute.
https://aws.amazon.com/about-aws/whats-new/2023/07/aws-cloudformation-deletion-policies-dev-test-cycle/

When attempting to use the AWS::LanguageExtensions within the Template below including the "RetainExceptOnCreate" Value for the DeletionPolicy Attribute, you encounter the following error:
Template:

Transform: 'AWS::LanguageExtensions'
Resources:
  S3:
    DeletionPolicy: RetainExceptOnCreate
    Type: AWS::S3::Bucket

Error:

Transform AWS::LanguageExtensions failed with: Unrecognized DeletionPolicy RetainExceptOnCreate for resource S3. Rollback requested by user.

Expected behavior

The expected behavior is that the AWS::LanguageExtensions Transform would be able to interpret RetainExceptOnCreate as a valid string to be used within the DeletionPolicy Attribute.

I suspect that there is a list of strings anticipated for the DeletionPolicy Attribute, and "RetainExceptOnCreate" needs to be added into the list of strings

Observed behavior

Currently the Language Extension throws the error below:

Transform AWS::LanguageExtensions failed with: Unrecognized DeletionPolicy RetainExceptOnCreate for resource S3. Rollback requested by user.

Test cases

Please include a minimal CloudFormation template here that reproduces the issue

Transform: 'AWS::LanguageExtensions'
Resources:
  S3:
    DeletionPolicy: RetainExceptOnCreate
    Type: AWS::S3::Bucket

You'll be met with the error right away within the Stack Events.

Additional context

Anything else we should know?
N/A

@kallu
Copy link

kallu commented Dec 21, 2023

Have you tested this recently? For me it did work today.

@derekps
Copy link

derekps commented Dec 21, 2023

@kallu It does indeed work now. I guess the feature was added but this Issue was ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants