Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): add localized description to AWSCognitoAuthError #3929

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Dec 5, 2024

Issue #

Description

Add localized description to the AWSCognitoAuthError to avoid any confusion where system makes a description itself.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner December 5, 2024 04:32
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 74 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (ed263d7) to head (98f09f0).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...AuthPlugin/Models/Errors/AWSCognitoAuthError.swift 0.00% 74 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3929      +/-   ##
==========================================
- Coverage   67.79%   67.67%   -0.12%     
==========================================
  Files        1124     1125       +1     
  Lines       51984    52075      +91     
==========================================
  Hits        35242    35242              
- Misses      16742    16833      +91     
Flag Coverage Δ
API_plugin_unit_test 70.33% <ø> (ø)
AWSPluginsCore 70.36% <ø> (ø)
Amplify 47.89% <ø> (ø)
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 73.43% <0.00%> (-0.35%) ⬇️
DataStore_plugin_unit_test 83.29% <ø> (-0.15%) ⬇️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 63.11% <ø> (ø)
Predictions_plugin_unit_test 35.49% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 76.88% <ø> (ø)
unit_tests 67.67% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsh62 harsh62 merged commit 89d3b72 into main Dec 5, 2024
93 checks passed
@harsh62 harsh62 deleted the cognito-auth-error-localized-description branch December 5, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants