From 59eb80739cb12c8f1fa4713d583e109f73ff5b3e Mon Sep 17 00:00:00 2001 From: Sebastian Villena <97059974+ruisebas@users.noreply.github.com> Date: Fri, 6 Sep 2024 18:00:16 -0400 Subject: [PATCH 1/4] chore: Avoid updating labels on closed issues [skip ci] (#3856) --- .github/workflows/issue_comment.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/issue_comment.yml b/.github/workflows/issue_comment.yml index 822ff84a1c..2670f9d622 100644 --- a/.github/workflows/issue_comment.yml +++ b/.github/workflows/issue_comment.yml @@ -21,6 +21,7 @@ jobs: adjust-labels: runs-on: ubuntu-latest + if: ${{ github.event.issue.state == 'open' }} permissions: issues: write env: From 0b255bc70105b351b07ecd95ac832789cd4e773c Mon Sep 17 00:00:00 2001 From: Sebastian Villena <97059974+ruisebas@users.noreply.github.com> Date: Fri, 13 Sep 2024 15:46:36 -0400 Subject: [PATCH 2/4] chore: Marking Storage's key-based API as deprecated in the Category implementation. (#3863) --- .../Storage/StorageCategory+ClientBehavior.swift | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Amplify/Categories/Storage/StorageCategory+ClientBehavior.swift b/Amplify/Categories/Storage/StorageCategory+ClientBehavior.swift index 55b69bbe43..e9197c34ce 100644 --- a/Amplify/Categories/Storage/StorageCategory+ClientBehavior.swift +++ b/Amplify/Categories/Storage/StorageCategory+ClientBehavior.swift @@ -9,6 +9,7 @@ import Foundation extension StorageCategory: StorageCategoryBehavior { + @available(*, deprecated, message: "Use getURL(path:options:)") @discardableResult public func getURL( key: String, @@ -25,6 +26,7 @@ extension StorageCategory: StorageCategoryBehavior { try await plugin.getURL(path: path, options: options) } + @available(*, deprecated, message: "Use downloadData(path:options:)") @discardableResult public func downloadData( key: String, @@ -41,6 +43,7 @@ extension StorageCategory: StorageCategoryBehavior { plugin.downloadData(path: path, options: options) } + @available(*, deprecated, message: "Use downloadFile(path:options:)") @discardableResult public func downloadFile( key: String, @@ -59,6 +62,7 @@ extension StorageCategory: StorageCategoryBehavior { plugin.downloadFile(path: path, local: local, options: options) } + @available(*, deprecated, message: "Use uploadData(path:options:)") @discardableResult public func uploadData( key: String, @@ -77,6 +81,7 @@ extension StorageCategory: StorageCategoryBehavior { plugin.uploadData(path: path, data: data, options: options) } + @available(*, deprecated, message: "Use uploadFile(path:options:)") @discardableResult public func uploadFile( key: String, @@ -95,6 +100,7 @@ extension StorageCategory: StorageCategoryBehavior { plugin.uploadFile(path: path, local: local, options: options) } + @available(*, deprecated, message: "Use remove(path:options:)") @discardableResult public func remove( key: String, @@ -111,6 +117,7 @@ extension StorageCategory: StorageCategoryBehavior { try await plugin.remove(path: path, options: options) } + @available(*, deprecated, message: "Use list(path:options:)") @discardableResult public func list( options: StorageListOperation.Request.Options? = nil From 4782923d87414c56ac0d9716e9ebd8a2cc84aa0b Mon Sep 17 00:00:00 2001 From: Vincent Tran Date: Fri, 13 Sep 2024 13:03:06 -0700 Subject: [PATCH 3/4] chore: Update typo in README (#3859) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index bb77a62dbf..28552426e4 100644 --- a/README.md +++ b/README.md @@ -136,7 +136,7 @@ Amplify requires Xcode 15.0 or later for all the supported platforms. ## Escape Hatch -All services and features not listed in the [**Features/API sectios**](#featuresapis) are supported via the [Swift SDK](https://github.com/awslabs/aws-sdk-swift) or if supported by a category can be accessed via the Escape Hatch like below: +All services and features not listed in the [**Features/API sections**](#featuresapis) are supported via the [Swift SDK](https://github.com/awslabs/aws-sdk-swift) or if supported by a category can be accessed via the Escape Hatch like below: ```swift import Amplify From 39de25da46ddcef642f6140cc2958ff90de6a7b6 Mon Sep 17 00:00:00 2001 From: Di Wu Date: Mon, 16 Sep 2024 13:31:28 -0700 Subject: [PATCH 4/4] fix(analytics): iterate sqlite rows with failableNext (#3857) --- .../Analytics/LocalStorage/AnalyticsEventSQLStorage.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/AmplifyPlugins/Internal/Sources/InternalAWSPinpoint/Analytics/LocalStorage/AnalyticsEventSQLStorage.swift b/AmplifyPlugins/Internal/Sources/InternalAWSPinpoint/Analytics/LocalStorage/AnalyticsEventSQLStorage.swift index c0597a6e98..260c982b1d 100644 --- a/AmplifyPlugins/Internal/Sources/InternalAWSPinpoint/Analytics/LocalStorage/AnalyticsEventSQLStorage.swift +++ b/AmplifyPlugins/Internal/Sources/InternalAWSPinpoint/Analytics/LocalStorage/AnalyticsEventSQLStorage.swift @@ -142,9 +142,9 @@ class AnalyticsEventSQLStorage: AnalyticsEventStorage { ORDER BY timestamp ASC LIMIT ? """ - let rows = try dbAdapter.executeQuery(queryStatement, [limit]) + let rows = try dbAdapter.executeQuery(queryStatement, [limit]).makeIterator() var result = [PinpointEvent]() - for element in rows { + while let element = try rows.failableNext() { if let event = PinpointEvent.convertToEvent(element) { result.append(event) }