feat(Auth): Add Passwordless Sign In with OTP implementation #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feat/auth-passwordless #3386 +/- ##
==========================================================
+ Coverage 67.74% 68.13% +0.38%
==========================================================
Files 1086 1089 +3
Lines 36217 36308 +91
==========================================================
+ Hits 24535 24738 +203
+ Misses 11682 11570 -112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thisisabhash
approved these changes
Nov 29, 2023
| // | ||
| import Amplify | ||
|
|
||
| public struct AWSAuthConfirmSignInWithMagicLinkOptions { |
There was a problem hiding this comment.
may be we can add a todo here once we finalize on the options
...AuthPluginUnitTests/TaskTests/ClientBehaviorTests/SignIn/AWSAuthSignInWithOTPTaskTests.swift
Outdated
Show resolved
Hide resolved
thisisabhash
pushed a commit
that referenced
this pull request
Dec 13, 2023
* feat(Auth): Add Passwordless Sign In with OTP implementation * update namespacing * added new options * worked on review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR has the following changes:
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.