Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): add metadata support to uploads #3295

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Conversation

phantumcode
Copy link
Contributor

@phantumcode phantumcode commented Oct 13, 2023

Issue #

#2744

Description

  • Include metadata in s3 uploads

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner October 13, 2023 16:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #3295 (032ea2c) into main (efc0061) will decrease coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is 20.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3295      +/-   ##
==========================================
- Coverage   64.32%   64.28%   -0.04%     
==========================================
  Files        1075     1075              
  Lines       35880    35887       +7     
==========================================
- Hits        23079    23070       -9     
- Misses      12801    12817      +16     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 66.15% <ø> (ø)
Amplify 47.84% <ø> (-0.02%) ⬇️
Analytics_plugin_unit_test 81.37% <ø> (ø)
Auth_plugin_unit_test 73.98% <ø> (-0.11%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.07% <ø> (+0.01%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 60.29% <ø> (ø)
Storage_plugin_unit_test 54.18% <20.00%> (-0.06%) ⬇️
unit_tests 64.28% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lugin/AWSS3StoragePlugin+AsyncClientBehavior.swift 96.47% <100.00%> (+0.04%) ⬆️
.../AWSS3StorageService+GetPreSignedURLBehavior.swift 78.57% <100.00%> (+0.79%) ⬆️
...n/Dependency/AWSS3PreSignedURLBuilderAdapter.swift 12.82% <0.00%> (ø)
...Storage/AWSS3StorageService+DownloadBehavior.swift 0.00% <0.00%> (ø)
...e/Storage/AWSS3StorageService+UploadBehavior.swift 0.00% <0.00%> (ø)
.../AWSS3StorageService+MultiPartUploadBehavior.swift 0.00% <0.00%> (ø)
...upport/Internal/StorageMultipartUploadClient.swift 1.75% <0.00%> (-0.04%) ⬇️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phantumcode phantumcode temporarily deployed to Fortify October 13, 2023 19:00 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to Fortify October 13, 2023 19:19 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to Fortify October 13, 2023 19:42 — with GitHub Actions Inactive
@phantumcode phantumcode temporarily deployed to Fortify October 13, 2023 19:46 — with GitHub Actions Inactive
@phantumcode phantumcode merged commit aef39fd into main Oct 18, 2023
77 checks passed
@phantumcode phantumcode deleted the fix/storage_metadata branch October 18, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants