-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datastore): Continue initial sync if atleast one model syncs successfully and other models fail due to Unauthorized API error #3224
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #3224 +/- ##
==========================================
- Coverage 64.63% 64.62% -0.01%
==========================================
Files 1091 1091
Lines 37071 37081 +10
==========================================
+ Hits 23962 23965 +3
- Misses 13109 13116 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Issue #
3136
Description
Initial Sync should succeed if atleast one model sync succeeds. In this PR, additional checks are added to catch Unauthorized APIError received for some models during Initial sync and return success.
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.