fix(datastore): using URLProtocol monitor auth request headers #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
had a problem deploying
to
IntegrationTest
GitHub Actions
Failure
5d
changed the title
lawmicha
reviewed
Sep 14, 2023
...stApp/AWSDataStorePluginAuthIAMTests/AWSDataStoreCategoryPluginIAMAuthIntegrationTests.swift
Outdated
Show resolved
Hide resolved
lawmicha
approved these changes
Sep 14, 2023
phantumcode
added a commit
that referenced
this pull request
Sep 21, 2023
* main: fix(core): add Foundation HTTP client for watchOS / tvOS (#3230) chore: finalize release 2.18.0 [skip ci] chore: release 2.18.0 [skip ci] feat: Setting mininum watchOS version to 9 (#3229) change swift-tools-version to 5.7 (#3193) chore: finalize release 2.17.2 [skip ci] chore: release 2.17.2 [skip ci] fix(datastore): use unwrapped storageEngine to perform datastore operations (#3204) fix(datastore): using URLProtocol monitor auth request headers (#3221) ci: add dependency review workflow (#3132) fix(api): change request interceptors applying logic (#3190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description
We used to use custome interceptor to verify the final request headers for datastore multiAuth test cases. As we've changed the order of applying custome interceptors, this approach is no longer workable for verifying the final request.
This PR change to use a subclass of
URLProtocolto monitor the final request and publish the header info to test cases.General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.