fix: use s3.upload instead of s3.putObject #13493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AmplifyCLI-PR-Testing failed |
0618
approved these changes
Dec 26, 2023
sobolk
approved these changes
Dec 26, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Replaces usage of
s3.putObjectwiths3.uploadwhen uploading project files.s3.uploadhandles retries / chunking / multipart when uploading whereas putObject does not. On slow networks this caused errors like the ones linked below.Issue #, if available
#7632
#4113
#8239
#4183
Description of how you validated changes
Validated changes locally by simulating a slow network using throttle and making changes to a project with a large lambda zip file. Before the change I got the timeout error and after the change the upload went through.
Writing an e2e test for this may be more effort than it's worth. The throttle utility I used to simulate a slow network requires running as sudo which means it will be difficult to use in CI/CD. Open to suggestions.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.