Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CDK CLI to match CDK lib #2172

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Upgrade CDK CLI to match CDK lib #2172

merged 1 commit into from
Oct 30, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Oct 30, 2024

Problem

Introduced in #2164

image

Changes

npm upgrade aws-cdk

Validation

this Pr checks.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Oct 30, 2024
@sobolk sobolk requested a review from a team as a code owner October 30, 2024 21:58
Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: e31cc92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@rtpascual rtpascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it lol.

@sobolk sobolk merged commit ce44b1a into main Oct 30, 2024
68 of 69 checks passed
@sobolk sobolk deleted the fix-tests-3242 branch October 30, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants