Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate errors to AppSync #2162

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Oct 29, 2024

Problem

When errors are thrown in Lambda they are not propagated to upstream AppSync instance.

This is due to asynchronous dispatch from AppSync to Lambda.

Changes

The changes in this PR are to catch and forward as many errors as possible.

  1. Add section in conversation turn executor that attempts to send error back to AppSync in a form of mutation (this is best effort as communication to AppSync might be impaired as well).
  2. Refactor conversation turn executor's initialization logic to make it lazy. So that validation errors from that phase are captured and sent to AppSync as well.
  3. Adjusted tests and e2e mock schemas to accommodate extra errors field.

Validation

  1. Added tests (unit and e2e)
  2. Manual validation with upstream.

Screenshot from e2e testing with AppSync using snapshot release:
image

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Oct 29, 2024
Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 4a7fd00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@aws-amplify/ai-constructs Minor
@aws-amplify/backend-ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sobolk sobolk marked this pull request as ready for review October 30, 2024 23:06
@sobolk sobolk requested a review from a team as a code owner October 30, 2024 23:06
@sobolk sobolk merged commit 37dd87c into main Oct 31, 2024
74 checks passed
@sobolk sobolk deleted the conversation-handler-error-forwarding branch October 31, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants