fix: add cdk error mapping for error 'command cdk not found' #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0951101 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sobolk
reviewed
Dec 4, 2024
| errorRegex: /Command cdk not found/, | ||
| humanReadableErrorMessage: 'Unable to detect cdk installation', | ||
| resolutionMessage: | ||
| "Install the dependencies in your project by running 'yarn install' or 'npm install'", |
There was a problem hiding this comment.
Suggested change
| "Install the dependencies in your project by running 'yarn install' or 'npm install'", | |
| "Make sure that dependencies in your project are installed with your package manager.", |
or "Make sure that dependencies in your project are installed with your package manager. For example, by running 'yarn install' or 'npm install'",
We also support pnpm. The message should be formed in such a way that customer is encouraged to try their desired package manager. Otherwise some will just run these commands blindly.
rtpascual
approved these changes
Dec 4, 2024
awsluja
approved these changes
Dec 4, 2024
sobolk
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sometimes yarn customers are running into this issue during sandbox run. I'm able to reproduce this by having sandbox running with yarn and deleting node_modules (or perhaps a custom clean script) and making a file change in the backend.
Changes
Add error mapping to let customers know to install their dependencies again.
Validation
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.