Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all optional props for NodejsFunction to be passed to defineFunction in @aws-amplify/backend-function #1968

Open
ataylorme opened this issue Sep 6, 2024 · 1 comment
Labels
feature-request New feature or request function Issue pertaining to Amplify Function p4

Comments

@ataylorme
Copy link
Contributor

Environment information

System:
  OS: macOS 14.6.1
  CPU: (8) arm64 Apple M2
  Memory: 140.08 MB / 16.00 GB
  Shell: /bin/zsh
Binaries:
  Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
  Yarn: undefined - undefined
  npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
  pnpm: undefined - undefined
NPM Packages:
  @aws-amplify/auth-construct: 1.3.0
  @aws-amplify/backend: 1.2.0
  @aws-amplify/backend-auth: 1.1.3
  @aws-amplify/backend-cli: 1.2.5
  @aws-amplify/backend-data: 1.1.3
  @aws-amplify/backend-deployer: 1.1.0
  @aws-amplify/backend-function: 1.3.4
  @aws-amplify/backend-output-schemas: 1.2.0
  @aws-amplify/backend-output-storage: 1.1.1
  @aws-amplify/backend-secret: 1.1.0
  @aws-amplify/backend-storage: 1.1.2
  @aws-amplify/cli-core: 1.1.2
  @aws-amplify/client-config: 1.3.0
  @aws-amplify/deployed-backend-client: 1.4.0
  @aws-amplify/form-generator: 1.0.1
  @aws-amplify/model-generator: 1.0.5
  @aws-amplify/platform-core: 1.0.7
  @aws-amplify/plugin-types: 1.2.1
  @aws-amplify/sandbox: 1.2.0
  @aws-amplify/schema-generator: 1.2.1
  aws-amplify: 6.5.4
  aws-cdk: 2.154.1
  aws-cdk-lib: 2.154.1
  typescript: 5.5.4
AWS environment variables:
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Describe the feature

Currently the FunctionProp type only allows for specific props.

Allow all optional props for NodejsFunction, such as logRetention, to be passed to defineFunction

Use case

  • Converting existing CDK functions using NodejsFunction to defineFunction from @aws-amplify/backend
  • Adding log retention to functions creating with defineFunction from @aws-amplify/backend
@ataylorme ataylorme added the pending-triage Incoming issues that need categorization label Sep 6, 2024
@ykethan ykethan added feature-request New feature or request function Issue pertaining to Amplify Function and removed pending-triage Incoming issues that need categorization labels Sep 6, 2024
@ataylorme ataylorme changed the title Allow all optional props for NodejsFunction to be passed to defineFunction in @aws-amplify/backend Allow all optional props for NodejsFunction to be passed to defineFunction in @aws-amplify/backend-function Sep 6, 2024
@ataylorme
Copy link
Contributor Author

@ykethan I created #1971 to implement this feature. It would be great to get it reviewed or at least the test run allowed so I can fix things as needed

@josefaidt josefaidt added the p4 label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request function Issue pertaining to Amplify Function p4
Projects
None yet
Development

No branches or pull requests

3 participants