diff --git a/.changeset/spicy-rules-speak.md b/.changeset/spicy-rules-speak.md new file mode 100644 index 0000000000..a845151cc8 --- /dev/null +++ b/.changeset/spicy-rules-speak.md @@ -0,0 +1,2 @@ +--- +--- diff --git a/.github/workflows/health_checks.yml b/.github/workflows/health_checks.yml index 290dc2a5ef..75ca3cef8e 100644 --- a/.github/workflows/health_checks.yml +++ b/.github/workflows/health_checks.yml @@ -392,7 +392,9 @@ jobs: - uses: ./.github/actions/setup_node - uses: ./.github/actions/restore_install_cache - run: git fetch origin - - run: npm run diff:check ${{ github.event.pull_request.base.sha }} + - run: npm run diff:check "$BASE_SHA" + env: + BASE_SHA: ${{ github.event.pull_request.base.sha }} check_pr_changesets: if: github.event_name == 'pull_request' && github.event.pull_request.user.login != 'github-actions[bot]' runs-on: ubuntu-latest @@ -406,9 +408,13 @@ jobs: - uses: ./.github/actions/setup_node - uses: ./.github/actions/restore_install_cache - name: Validate that PR has changeset - run: npx changeset status --since origin/${{ github.event.pull_request.base.ref }} + run: npx changeset status --since origin/"$BASE_REF" + env: + BASE_REF: ${{ github.event.pull_request.base.ref }} - name: Validate changeset is not missing packages - run: npx tsx scripts/check_changeset_completeness.ts ${{ github.event.pull_request.base.sha }} + run: npx tsx scripts/check_changeset_completeness.ts "$BASE_SHA" + env: + BASE_SHA: ${{ github.event.pull_request.base.sha }} - name: Validate that changeset has necessary dependency updates run: | npx changeset version