Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolesets with more people in the lobby #22

Open
Sigafoos opened this issue Mar 7, 2019 · 2 comments
Open

Rolesets with more people in the lobby #22

Sigafoos opened this issue Mar 7, 2019 · 2 comments
Labels
bug Something isn't working front end This issue involves the Elm front end
Milestone
1.0

Comments

@Sigafoos
Copy link
Collaborator

Sigafoos commented Mar 7, 2019

Scenario: Six people join. The leader chooses Vanilla Fiver. Things... probably do not go well.
@Sigafoos Sigafoos added the bug Something isn't working label Mar 7, 2019
@Sigafoos Sigafoos added this to the 1.0 milestone Mar 7, 2019
Sigafoos added a commit that referenced this issue Mar 8, 2019
@Sigafoos
Return an error if you choose a roleset with fewer slots than you hav…
f73aabc 
…e players (#22). Needs front end changes too.
@Sigafoos
Copy link
Collaborator Author

Sigafoos commented Mar 8, 2019

f73aabc will cause the server to return an error on this case, but the front end doesn't display it. @segfaultvicta hey buddy :)

@Sigafoos Sigafoos added the front end This issue involves the Elm front end label Mar 8, 2019
@Sigafoos Sigafoos mentioned this issue Mar 9, 2019
Merged
@Sigafoos
Copy link
Collaborator Author

This could also be solved by hiding rolesets with fewer roles than people in the lobby (once #8 is done).

Still, though: I think the client should display payloads with "message": "error" to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working front end This issue involves the Elm front end
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@Sigafoos