Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field: pass all html options #3145

Open
pjmuller opened this issue Aug 16, 2024 · 4 comments · May be fixed by #3443
Open

field: pass all html options #3145

pjmuller opened this issue Aug 16, 2024 · 4 comments · May be fixed by #3443
Labels
Enhancement Not necessarily a feature, but something has improved Help wanted We could use some help with this Stale exempt

Comments

@pjmuller
Copy link

Feature

https://docs.avohq.io/3.0/field-options.html#html only allow for style, classes, or data.
It would be great (just as like with mapkick_options for maps) that you pass ALL options to the html field (instead of only the whilelisted ones)

field :name, as: :text, html: {
  edit: {
    wrapper: {
      min: 1,
      max:  100,
      pattern: ...,
    }
}

(sidenote: when this same logic is used within actions, we can also consider #2803 closed)

Current workarounds

None

Additional context

This can (amongst other) help to create html validations where relevant

  • min
  • max
  • pattern
  • minlength
  • ...
Copy link
Contributor

github-actions bot commented Sep 1, 2024

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Sep 1, 2024
@Paul-Bob Paul-Bob moved this to To Do in Issues Sep 3, 2024
@Paul-Bob Paul-Bob added Enhancement Not necessarily a feature, but something has improved and removed Stale labels Sep 3, 2024
Copy link
Contributor

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Sep 22, 2024
@Paul-Bob Paul-Bob removed the Stale label Sep 22, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Oct 8, 2024
@Paul-Bob Paul-Bob removed the Stale label Oct 8, 2024
Copy link
Contributor

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Oct 24, 2024
@adrianthedev adrianthedev added Help wanted We could use some help with this Stale exempt and removed Stale labels Oct 24, 2024
@thiagoyoussef thiagoyoussef linked a pull request Nov 19, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Not necessarily a feature, but something has improved Help wanted We could use some help with this Stale exempt
Projects
Status: To Do
Development

Successfully merging a pull request may close this issue.

3 participants