Add mockgen source mode for generics + bls imports
#2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
danlaine,
darioush,
dboehm-avalabs,
joshua-kim,
abi87,
StephenButtolph,
ceyonur and
gyuho
as code owners
dhrubabasu
commented
Jan 16, 2024
scripts/mocks.mockgen.source.txt
Outdated
There was a problem hiding this comment.
This is the file that adds source mode mockgens. It seems like you can only exclude interfaces rather than specify which ones you want to mock which is... annoying
dhrubabasu
commented
Jan 16, 2024
| @@ -27,4 +27,22 @@ do | |||
|
|
|||
| done < "$input" | |||
|
|
|||
| # tuples of (source import path, comma-separated interface names to exclude, output file path) | |||
There was a problem hiding this comment.
Main change of this PR
dhrubabasu
changed the title
mockgen source mode for bls importsmockgen source mode for generics + bls imports
dhrubabasu
changed the title
mockgen source mode for generics + bls importsmockgen source mode for generics + bls imports
abi87
approved these changes
Jan 17, 2024
I think we can move to source for all of them. I haven't moved them all to source since I really really dislike the exclude_interfaces since it makes the mockgen file so much more confusing. Opened an issue in the uber repo to track resolution: uber-go/mock#140 |
StephenButtolph
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR codifies many of the mode=source mockgens that we've been doing manually (and more importantly adding it to CI)
How this works
Add mockgen source command
How this was tested
CI + manually