feat: pointcloud_preprocessor load from param #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <[email protected]>
knzo25
reviewed
Aug 1, 2024
|
|
||
|
|
||
| def launch_setup(context, *args, **kwargs): | ||
| # Pointcloud preprocessor parameters | ||
| concatenate_and_time_sync_node_param = ParameterFile( | ||
| param_file=LaunchConfiguration("concatenate_and_time_sync_node_param_path").perform( |
There was a problem hiding this comment.
.perform(context)
may be unnecessary
https://github.com/ros2/launch_ros/blob/38152b2d04c6b6f126d31726ac9e12888b2e2e1f/launch_ros/launch_ros/parameter_descriptions.py#L170
|
This PR #108 does the same thing but has the latest update, thus I will close this one. I will also test the suggestion from kenzo in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows pointcloud_preprocessor.launch.py to load the parameter from yaml file.
This PR should be merged together with autowarefoundation/autoware.universe#8300
Related links
Tests performed
Test with xx1 bag.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.