Allow remapping of the canbus topics #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Clephas <[email protected]>
Timple
force-pushed
the
feature/remap-argument
branch
from
6a66a79 to
05e2f88
Compare
|
In-general, passing topic names as launch arguments is an anti-pattern but in this case, launch files to automatically transition LifeCycle nodes are (I feel) more complex than they need to be so I'm OK with it. Thanks! |
JWhitleyWork
approved these changes
Jan 25, 2024
|
Thank you for the approval. Subtle ping for the merge. |
|
@wep21 ? |
|
@mitsudome-r @xmfcx Could someone in awf take a look at this PR? I don't have the write access to this repository. |
xmfcx
approved these changes
Mar 25, 2024
|
Closed-reopened to trigger bugged out CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our codebase expects a
can/txandcan/rxnotation. In ros1 we could simply remap in the node.However launching a bridge nowadays seems to involve 227 lines of launching 😄.
We're rather not duplicate all those so kindly request to be able to set the topic via an argument.