refactor(autoware_pointcloud_preprocessor): rework concatenate_pointcloud and time_synchronizer_node parameters #8509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
github-actions
bot
added
the
component:sensing
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
vividf
requested review from
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
meliketanrikulu,
miursh,
YoshiRi and
yukkysaito
as code owners
vividf
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8509 +/- ##
==========================================
- Coverage 23.96% 23.81% -0.15%
==========================================
Files 1382 1388 +6
Lines 102019 101936 -83
Branches 38886 38860 -26
==========================================
- Hits 24446 24281 -165
- Misses 75141 75178 +37
- Partials 2432 2477 +45
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yukkysaito
approved these changes
Aug 19, 2024
amadeuszsz
requested changes
Aug 20, 2024
| "properties": { | ||
| "timeout_sec": { | ||
| "type": "number", | ||
| "default": 0.1, |
There was a problem hiding this comment.
Assign default values as string
There was a problem hiding this comment.
Thanks! fixed them in 08ec218
| }, | ||
| "max_queue_size": { | ||
| "type": "integer", | ||
| "default": 5, |
There was a problem hiding this comment.
Assign default values as string
| "properties": { | ||
| "timeout_sec": { | ||
| "type": "number", | ||
| "default": 0.033, |
There was a problem hiding this comment.
Assign default values as string
| }, | ||
| "max_queue_size": { | ||
| "type": "integer", | ||
| "default": 5, |
There was a problem hiding this comment.
Assign default values as string
Signed-off-by: vividf <[email protected]>
…time_synchronizer_parameter
Signed-off-by: vividf <[email protected]>
…onizer_parameter' of github.com:vividf/autoware.universe into refactor/rework_concatenate_pointclouds_and_time_synchronizer_parameter
…time_synchronizer_parameter
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…loud and time_synchronizer_node parameters (autowarefoundation#8509) * feat: rewort concatenate pointclouds and time synchronizer parameter Signed-off-by: vividf <[email protected]> * chore: fix launch files Signed-off-by: vividf <[email protected]> * chore: fix schema Signed-off-by: vividf <[email protected]> * chore: fix schema Signed-off-by: vividf <[email protected]> * chore: fix integer and number default value in schema Signed-off-by: vividf <[email protected]> * chore: add boundary Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
…loud and time_synchronizer_node parameters (autowarefoundation#8509) * feat: rewort concatenate pointclouds and time synchronizer parameter Signed-off-by: vividf <[email protected]> * chore: fix launch files Signed-off-by: vividf <[email protected]> * chore: fix schema Signed-off-by: vividf <[email protected]> * chore: fix schema Signed-off-by: vividf <[email protected]> * chore: fix integer and number default value in schema Signed-off-by: vividf <[email protected]> * chore: add boundary Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following changes
nodelettonode.Note that I didn't update the readme since after this PR #8300 the readme file will change a lot (parameters are different).
I will update the readme in this PR #8300
Related links
Parent Issue:
How was this PR tested?
ros2 launch autoware_pointcloud_preprocessor concatenate_pointcloud.launch.xmland
ros2 launch autoware_pointcloud_preprocessor time_synchronizer_node.launch.xmlNotes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.