Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remaining_distance_time_calculator): skip calculation during parking #9013

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(remaining_distance_time_calculator): skip calculation during parking #9013

wants to merge 2 commits into from
+28 −1

Conversation

ismetatabay
Copy link
Member

@ismetatabay ismetatabay commented Oct 2, 2024 •
edited
Loading

Description

With this PR, the autoware_remaining_distance_time_calculator node stops calculating the remaining time and distance during parking scenarios and sends zero for both remaining time and distance as we discussed in Planning&Control WG Meeting 2024/09/26.

Related links

Parent Issue:

How was this PR tested?

Psim

Before this PR

2024-10-02.17-43-22.mp4

After this PR

2024-10-02.17-48-35.mp4

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@ismetatabay
init commit
d62447c 
Signed-off-by: ismetatabay <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@ismetatabay ismetatabay changed the title feat(remaining_distance_time_calculator): skip calculation durin parking feat(remaining_distance_time_calculator): skip calculation during parking Oct 2, 2024
@ismetatabay ismetatabay linked an issue Oct 3, 2024 that may be closed by this pull request
Remaining time and distance are incorrect in parking scenario #9023
Open
3 tasks
@ismetatabay ismetatabay marked this pull request as ready for review October 3, 2024 11:58
@ahmeddesokyebrahim ahmeddesokyebrahim added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 3, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 26.15%. Comparing base (01d9d67) to head (a52d9ca).

Files with missing lines Patch % Lines
...or/src/remaining_distance_time_calculator_node.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9013      +/-   ##
==========================================
- Coverage   26.16%   26.15%   -0.01%     
==========================================
  Files        1302     1303       +1     
  Lines       96917    96952      +35     
  Branches    39150    39155       +5     
==========================================
  Hits        25354    25354              
- Misses      68900    68935      +35     
  Partials     2663     2663
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 26.16% <ø> (+<0.01%) ⬆️ Carriedforward from 01d9d67

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmeddesokyebrahim
Copy link
Contributor

Thanks so much @ismetatabay for this contribution.
The PR looks clean and pretty much ready for merging.
I have only a single comment if you may agree with me.
Would it be ok to write some notes about this change under Activation and Timing in the package readme file ?

@ismetatabay
update readme
314e3a3 
Signed-off-by: ismetatabay <[email protected]>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Oct 3, 2024
@ismetatabay
Copy link
Member Author

@ahmeddesokyebrahim Thanks!, please check this commit and let me know if you have any concerns

ahmeddesokyebrahim
ahmeddesokyebrahim approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks a lot @ismetatabay !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmeddesokyebrahim ahmeddesokyebrahim ahmeddesokyebrahim approved these changes

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remaining time and distance are incorrect in parking scenario
2 participants
@ismetatabay @ahmeddesokyebrahim