Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] intensifier type mismatch between docs and code of AlgorithmConfigurationFacade #1162

Closed
bbudescu opened this issue Nov 18, 2024 · 4 comments
Assignees

Comments

@bbudescu
Copy link

In the table at the beginning of the "Facade" section of the "Getting Started" Guide, it is stated that the Algorithm Configuration facade is using Hyperband by default. However, when actually running the code, one can see that a "Default" Intensifier is actually returned by AlgorithmConfigurationFacade.get_intensifier()

@dengdifan
Copy link
Contributor

Hi,
Thanks for the information. The default intensifier for the AC facade should indeed be default. We will fix that in the next release!

@bbudescu
Copy link
Author

Hi,
Thanks for looking into the problem. Also, I can see that not long before I posted this issue, someone else also mentioned it in theirs (#1160). Sorry for the repost. It was just a coincidence. I actually skimmed through that one, but somehow missed the reference to this issue.

@bbudescu
Copy link
Author

I see you added #1165, which is exactly about this, so, from my point of view, this issue has become redundant. Should I just close it?

@benjamc
Copy link
Collaborator

benjamc commented Nov 21, 2024

Fixed in #1155. Thanks again.:)

@benjamc benjamc closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants