Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Integration of the different ML methods #91

Open
2 tasks
QuantumChemist opened this issue Aug 8, 2024 · 1 comment
Open
2 tasks

Better Integration of the different ML methods #91

QuantumChemist opened this issue Aug 8, 2024 · 1 comment
Assignees

Comments

@QuantumChemist
Copy link
Collaborator

QuantumChemist commented Aug 8, 2024

As autoplex grew organically with GAP in the beginning, the different ML (hyper)parameters and kwargs etc. are handled very differently. It would be best to refactor the code for making the code more consistent and unify the approaches for the different ML methods.

I would like to suggest that I and @YuanbinLiu work on this.

This issue might take longer to tackle.

TODO:

  • take data preprocessing out of ML fit step and make an own step (job?)
  • make data flow template (data-gen/build-rss, do_static_dft, collect_dft, preoprocess_data etc.)
@JaGeo
Copy link
Collaborator

JaGeo commented Aug 8, 2024

Agreed. I think for our next steps, the tests seem more important! And this can surely take a bit longer! Most important point for now is that the fitting works 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants