Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Package on PyPI #17

Open
DE0CH opened this issue Nov 25, 2022 · 4 comments
Open

Release Package on PyPI #17

DE0CH opened this issue Nov 25, 2022 · 4 comments

Comments

@DE0CH
Copy link
Collaborator

DE0CH commented Nov 25, 2022

Once it is ready, we can consider pushing it onto PyPI. I've already created a github workflow for that. All it needs now is the PYPI_API_TOKEN environment set the settings. I can't edit the settings, so I can't set it. Manuel, can you help with that?

@MLopez-Ibanez
Copy link
Contributor

Lets get #16 fixed first. I don't want to put a package in PyPI that is broken for Windows.

@DE0CH
Copy link
Collaborator Author

DE0CH commented Dec 9, 2022

What about PR #5? Should we merge it before releasing it, or release it in a future version?

@MLopez-Ibanez
Copy link
Contributor

What about PR #5? Should we merge it before releasing it, or release it in a future version?

It will take me sometime to review this code, it is a lot of new code. If you think having the package in PyPI is important, I'm happy to release it without it. If you think it is not that urgent, we can wait until that PR is merged.

@DE0CH
Copy link
Collaborator Author

DE0CH commented Dec 12, 2022

I see. Please take your time to review this code. I am ok with both releasing PyPI without it and releasing PyPI later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants