You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have seen the discussion here: #1013. And the recommendation there to just get a new refresh token and then forgetting it. This isn't a correct solution for me, this will fail our security reviews. Refresh tokens should be revoked when they are done with.
In my book we shouldn't expose a revoke token method but instead we should add it to the logic within the logout method as that is the only time a client would revoke the refresh token
Reproduction
Copy refresh token
Logout
Use refresh token
Expected: refresh token can't be used, Actual: refresh token still useable
Additional context
I would be really happy to submit a PR for this improvement
auth0-spa-js version
2.1.3
Which framework are you using (React, Angular, Vue...)?
React (wrapping auth0-spa-js)
Framework version
No response
Which browsers have you tested in?
Chrome, Firefox
The text was updated successfully, but these errors were encountered:
Checklist
Description
I have seen the discussion here: #1013. And the recommendation there to just get a new refresh token and then forgetting it. This isn't a correct solution for me, this will fail our security reviews. Refresh tokens should be revoked when they are done with.
In my book we shouldn't expose a revoke token method but instead we should add it to the logic within the logout method as that is the only time a client would revoke the refresh token
Reproduction
Additional context
I would be really happy to submit a PR for this improvement
auth0-spa-js version
2.1.3
Which framework are you using (React, Angular, Vue...)?
React (wrapping auth0-spa-js)
Framework version
No response
Which browsers have you tested in?
Chrome, Firefox
The text was updated successfully, but these errors were encountered: