Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Tests #17

Open
lloy0076 opened this issue Sep 30, 2019 · 4 comments
Open

Automated Tests #17

lloy0076 opened this issue Sep 30, 2019 · 4 comments

Comments

@lloy0076
Copy link
Contributor

It would be good to figure out how one might add some automated tests (so that it's less likely when others or I submit a PR we make a regression).

@aungwinthant
Copy link
Owner

Currently there are some tests in my local developments. I only tested driver's methods such as save, retrieved and deletes. It would be great if you can submit a PR, only if you got time.

@lloy0076
Copy link
Contributor Author

I'd be happy to work on that; I guess first I'll come up with a test plan.

I'll triage into:

  1. We need it yesterday;
  2. We need it now;
  3. It would be nice to have.

I think my criteria for (1) would be:

  1. A regression would completely break an application;
  2. A regression would stop it being installed at all;
  3. A regression would cause some sort of major security issue.

A "need it now" would probably be:

  1. A set of tests to perform a baseline regression suite.

The "futures" or "nice to haves" would be things like:

  1. Completely unlikely [but possible] edge cases;
  2. Tests for features not yet implemented (but soon to be implemented).

@lloy0076
Copy link
Contributor Author

PS. I'll start the suite up in Laravel 6.0 with an eye to keeping it compatible with L5.8.0 if possible.

@aungwinthant
Copy link
Owner

Thanks. I owe you a big time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants