Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line options don't override config file #47

Open
dtwilliamson opened this issue Dec 5, 2024 · 2 comments
Open

Command line options don't override config file #47

dtwilliamson opened this issue Dec 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dtwilliamson
Copy link

I'm not sure if the first run options set the values in files/config.json but subsequent runs seem to neither temporarily override them nor persistently overwrite them in the file.

@aunefyren
Copy link
Owner

If I remember correctly it does not override, only replace null values. This system should be overhauled now that I am doing a bunch of refactoring.

@aunefyren aunefyren added the enhancement New feature or request label Dec 5, 2024
@dtwilliamson
Copy link
Author

Perhaps there should be a hierarchy like command-line-options override environment-variables override config-file. I think a lot of software works that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants