Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_root argument of Augment.augment() not considered when loading from cache #2

Open
hagenw opened this issue Jan 17, 2024 · 0 comments

Comments

@hagenw
Copy link
Member

hagenw commented Jan 17, 2024

The remove_root argument influences how the exact file path looks in the returned augmented index (and also where the augmented files are stored). When auglib.Augment.augment() can find a matching augmentation in the cache it returns the index for that augmentation, and does not consider remove_root. On one hand, this is a feature as it does not have to run the augmentation again, when only the path should change. On the other hand, it might break code that follows and expects that the file path looks different.

Not sure yet, how we can improve the current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant