-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust example on Datacard based on actual mime-type of media file #89
Comments
Having the |
I agree, but I'm afraid that will not be easy to achieve afterwards. We can only easily access information on sampling rate, duration and other media related properties, as we currently store them in the dependency table when publishing a dataset. Otherwise we would need to download every single media file to get those statistics. If we really think we need that information (and maybe others about text media files), we will have to extend the dependency table in |
I see, downloading all files might be cumbersome for the larger text datasets, so, it makes sense to skip this for the moment, unless we have a suitable text container format other than plain text, which supports metadata. |
But even then you would have to download all files to collect the metadata over all of them. |
You could also envision a central database, that stores such metadata, but our goal was to be de-central with
I would have nothing against a central database, but I think it should not become mandatory to use - for a specific backend deployment. But probably then it is hard to implement. What one thinks of first is a kind of hook mechanism. Artifactory has a webhook mechanism too, but these are too late in the process chain and require that you implement a rest service that executes for such a thing. So overkill. On the client side there are other problems: such things are often implemented as decorators so it would not be too involved to implement say |
Good point. I think when we want to store additional information during For the approach with the database, I could indeed envision that we have one internally, that is used when creating the HTML overview pages. And can maybe also accessed by single users to request entries. But I would not fill such a database directly during publication, but have a cron job on a compute server running, filling up the database. The only downside would be that it would fill up the shared cache on the compute servers with all datasets. But maybe, we can also call this a feature? |
At the moment, we display all example media files as audio on a datacard, e.g.
This also works for video files, but displays only the audio.
Further we select the example file to show based on its duration.
I would propose the following improvement:
<video>
element instead of the<audio>
element and not showing a waveform for themduration
is always set to0.0
for those media files. But we might expand for what file types we show an example, by changing this behavior.For both points to work, we will need to check what is the mimetype of a corresponding media file.
Another question that arises is, how to handle examples for datasets that contain a mixture of different media types. At the moment we use the dependency table of a dataset to select a meaningful example, but the dependency table stores no information about the mime type of the included file.
The text was updated successfully, but these errors were encountered: