Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct versionized DevTool front-end #6

Open
auchenberg opened this issue Jan 21, 2016 · 5 comments
Open

Use correct versionized DevTool front-end #6

auchenberg opened this issue Jan 21, 2016 · 5 comments

Comments

@auchenberg
Copy link
Owner

Different versions of Chrome supports different features in DevTools, in order to make DevTools Remote work in current and future versions, then it should load the correct versionized DevTool front-end.

Steps:

  • Detect WebKit Version
  • Send that to API when creating a new session
  • Load correct front-end version
@kurtextrem
Copy link

You may want to detect the Blink version, rather than the WebKit version :)

@auchenberg
Copy link
Owner Author

@kurtextrem
Copy link

Oh, well then. My bad!

@kzahel
Copy link

kzahel commented Mar 3, 2017

I tried having a Canary (58) connect to current stable (56) and it didn't work so great. There was some flickering on the image.
https://github.com/auchenberg/devtools-remote/blob/master/server.js#L111
'chrome-devtools://devtools/remote/serve_rev/@d19c087b9bfdf76a8af91e2f0a0e791bf2ffcafa/inspector.html?ws=' + webSocketUrl + '&remoteFrontend=true&dockSide=unlocked&experiments=true'

It looks like you hard coded in a revision. Can you describe the process by which you selected that revision?

@auchenberg
Copy link
Owner Author

@kzahel The DevTools version is selected on a per-commit basis. No special policy or process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants