Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dataset, model and property names #158

Open
6 of 7 tasks
Tracked by #241
sirex opened this issue Oct 7, 2021 · 4 comments · Fixed by #327 · May be fixed by atviriduomenys/manifest#2970
Open
6 of 7 tasks
Tracked by #241

Check dataset, model and property names #158

sirex opened this issue Oct 7, 2021 · 4 comments · Fixed by #327 · May be fixed by atviriduomenys/manifest#2970
Assignees
Labels

Comments

@sirex
Copy link
Collaborator

sirex commented Oct 7, 2021

spinta check should validate dataset, model and property names according to requirements for codenames. Especially it should check if there are no trailing spaces.

Enable this functionality only on spinta check --names.

  • Check if dataset, model and property names uses only allowed symbols.
  • Check if dataset names are all lowercase.
  • Check if model names are in UpperCameCase.
  • Check if property names are in snake_case.
  • Do not allow extra /at the start or end of dataset names.
  • Do not allow empty // in dataset name.
  • Allow __ prefix in all names, __ marks deleted nodes.
@sirex sirex moved this to Todo in Portalo plėtra Apr 21, 2022
@sirex sirex removed the status in Portalo plėtra May 6, 2022
@sirex sirex moved this to Todo in Portalo plėtra Jun 7, 2022
@sirex sirex removed the status in Portalo plėtra Jun 7, 2022
@sirex sirex moved this to Todo in Portalo plėtra Jun 8, 2022
@sirex sirex removed the status in Portalo plėtra Jun 8, 2022
@sirex sirex added this to Palaikymas Oct 7, 2022
@Gediminas-msc Gediminas-msc moved this to In Progress in Palaikymas Nov 13, 2022
@Gediminas-msc Gediminas-msc self-assigned this Nov 13, 2022
@sirex sirex removed the status in Palaikymas Nov 14, 2022
@Gediminas-msc Gediminas-msc moved this to In Progress in Palaikymas Nov 15, 2022
@Gediminas-msc
Copy link
Contributor

Gediminas-msc commented Nov 17, 2022

Could you explain what this means: "Check if dataset, model and property names uses only allowed symbols."?

@Gediminas-msc Gediminas-msc linked a pull request Nov 17, 2022 that will close this issue
@sirex
Copy link
Collaborator Author

sirex commented Nov 17, 2022

Could you explain what this means: "Check if dataset, model and property names uses only allowed symbols."?

This is explained here: https://atviriduomenys.readthedocs.io/dsa/kodiniai-pavadinimai.html

@Gediminas-msc Gediminas-msc moved this from In Progress to Review in Palaikymas Nov 17, 2022
@sirex sirex removed this from Portalo plėtra Nov 21, 2022
@sirex sirex removed the status in Palaikymas Nov 28, 2022
@Gediminas-msc Gediminas-msc moved this to In Progress in Palaikymas Nov 30, 2022
@Gediminas-msc Gediminas-msc removed the status in Palaikymas Nov 30, 2022
@Gediminas-msc Gediminas-msc moved this to In Progress in Palaikymas Nov 30, 2022
@Gediminas-msc Gediminas-msc moved this from In Progress to Review in Palaikymas Dec 1, 2022
@Gediminas-msc Gediminas-msc moved this from Review to In Progress in Palaikymas Dec 2, 2022
@Gediminas-msc
Copy link
Contributor

Gediminas-msc commented Dec 2, 2022

Updated terminal command:
spinta check --check_names

@Gediminas-msc Gediminas-msc moved this from In Progress to Review in Palaikymas Dec 2, 2022
@sirex sirex removed the status in Palaikymas Dec 2, 2022
@Gediminas-msc Gediminas-msc moved this to In Progress in Palaikymas Dec 5, 2022
@Gediminas-msc Gediminas-msc moved this from In Progress to Review in Palaikymas Dec 5, 2022
@sirex sirex removed the status in Palaikymas Dec 12, 2022
@Gediminas-msc Gediminas-msc moved this to In Progress in Palaikymas Dec 14, 2022
@Gediminas-msc Gediminas-msc moved this from In Progress to Review in Palaikymas Dec 22, 2022
@Gediminas-msc Gediminas-msc removed their assignment Dec 28, 2022
@sirex sirex removed the status in Palaikymas Mar 6, 2023
@sirex sirex moved this from Done to Deploy in Palaikymas Dec 19, 2023
@sirex sirex moved this from Deploy to Test in Palaikymas Dec 23, 2023
@sirex sirex linked a pull request Jun 7, 2024 that will close this issue
@sirex
Copy link
Collaborator Author

sirex commented Jun 7, 2024

Atidarau užduotį, kadangi nėra iki galo sutvarkytas tikrinimas manifest repozitorijoje, žiūrėti:

@sirex sirex reopened this Jun 7, 2024
@sirex sirex moved this from Test to Todo in Palaikymas Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
3 participants