Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should "total commands" include split_at_pipe? #2538

Open
amonks opened this issue Jan 9, 2025 · 0 comments
Open

should "total commands" include split_at_pipe? #2538

amonks opened this issue Jan 9, 2025 · 0 comments

Comments

@amonks
Copy link

amonks commented Jan 9, 2025

Very cool program! Thanks for writing it!

Running atuin stats (after a fresh install and import) I was surprised to see that my "unique commands" number was greater than my "total commands" number:

☭ ~ ⋊> atuin stats
[▮▮▮▮▮▮▮▮▮▮] 503 go test
[▮▮▮▮▮▮▮▮  ] 442 vim
[▮▮▮▮▮▮▮▮  ] 418 git checkout
[▮▮▮▮▮▮▮▮  ] 412 rm
[▮▮▮▮▮▮▮   ] 401 grep
[▮▮▮▮▮▮▮   ] 393 go run
[▮▮▮▮▮     ] 298 cat
[▮▮▮▮▮     ] 287 curl
[▮▮▮▮▮     ] 261 fly
[▮▮▮▮      ] 232 echo
Total commands:   8575
Unique commands:  9367

Looking at source, these two figures actually count different sets of commands:

  • Unique counts both full commands and the results of split_at_pipe
  • Total counts only full commands

This feels wrong to me: since "total" and "unique" are presented together, I think they ought to refer to the same set of commands. (I don't have an opinion about whether that set should or should not include split_at_pipe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant