Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Changes for SSH No Ports v5.0.0 #609

Closed
2 tasks done
XavierChanth opened this issue Dec 5, 2023 · 3 comments
Closed
2 tasks done

Breaking Changes for SSH No Ports v5.0.0 #609

XavierChanth opened this issue Dec 5, 2023 · 3 comments
Assignees

Comments

@XavierChanth
Copy link
Member

XavierChanth commented Dec 5, 2023

Placeholder ticket to capture breaking changes that need to be made for version 5.0.0

Tasks

Preview Give feedback
@XavierChanth XavierChanth self-assigned this Dec 5, 2023
@XavierChanth XavierChanth pinned this issue Dec 5, 2023
@XavierChanth XavierChanth changed the title Breaking Changes for v5.0.0 Breaking Changes for SSH No Ports v5.0.0 Jan 9, 2024
@XavierChanth
Copy link
Member Author

@gkc in v5, maybe we should try to eliminate the $( sshnp ... ) syntax, instead having sshnp call the ssh command using Process.run, and stream it to stdout / stderr? That way we can run sshrv internally, rather than needing a separate sshrv process.

@gkc
Copy link
Contributor

gkc commented Jan 9, 2024

Yes, I think that would be a very good idea.

@XavierChanth
Copy link
Member Author

v5 is released, closing this

@XavierChanth XavierChanth unpinned this issue Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants