Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move parameters from SDK to CLI #573

Closed
Tracked by #346
XavierChanth opened this issue Nov 16, 2023 · 5 comments · Fixed by #592
Closed
Tracked by #346

Move parameters from SDK to CLI #573

XavierChanth opened this issue Nov 16, 2023 · 5 comments · Fixed by #592
Assignees
@gkc @XavierChanth

Comments

@XavierChanth
Copy link
Member

From a conversation with @gkc:

  • Move --legacy-daemon, --ssh-client from noports_core to sshnoports package
  • Extends the noports_core parser in sshnoports with the additional parsing
@XavierChanth XavierChanth changed the title Remove Implementation leakage into SshnpParams Move parameters from SDK to CLI Nov 16, 2023
@XavierChanth XavierChanth mentioned this issue Nov 16, 2023
Closed
@gkc
Copy link
Contributor

gkc commented Nov 20, 2023

@XavierChanth Shall I pick this one up?

@XavierChanth
Copy link
Member Author

@XavierChanth Shall I pick this one up?

If you can, that would be great!

@gkc
Copy link
Contributor

gkc commented Nov 23, 2023

@XavierChanth I'll do this one tomorrow morning. I'm still thinking about #572 (comment)

@gkc
Copy link
Contributor

gkc commented Nov 27, 2023

@XavierChanth I've been twisting myself into knots trying to do this; dealing with the ArgParser and the args list and extending the arg parser in sshnoports package is straightforward enough, but removing those two args from SshnpParams has a large ripple effect. I'm not sure this is worth the effort ...

@XavierChanth
Copy link
Member Author

I'll see if I can take a stab at this

@XavierChanth XavierChanth mentioned this issue Nov 28, 2023
Merged
@gkc gkc closed this as completed in #592 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkc gkc

@XavierChanth XavierChanth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move ssh-client & legacy-daemon from core to cli only atsign-foundation/noports
2 participants
@gkc @XavierChanth