Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-interactive element <form> should not be assigned mouse or keyboard event listeners. #1551

Open
cpswan opened this issue Nov 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cpswan
Copy link
Member

cpswan commented Nov 19, 2024

Describe the bug

Warning from npm run build whilst building admin webapp

vite v5.4.6 building for production...
transforming (33) node_modules/svelte/src/runtime/easing/index.js10:00:42 AM [vite-plugin-svelte] /home/chris/git/github.com/atsign-foundation/noports/apps/admin/webapp/src/lib/InPlaceEdit.svelte:41:4 A11y: Non-interactive element <form> should not be assigned mouse or keyboard event listeners.
39:
40: {#if editing}
41:     <form on:submit|preventDefault={submit} on:keydown={keydown}>
        ^
42:         <input bind:value on:blur={submit} {required} use:focus/>
43:     </form>
10:00:42 AM [vite-plugin-svelte] /home/chris/git/github.com/atsign-foundation/noports/apps/admin/webapp/src/lib/InPlaceEdit.svelte:45:4 A11y: <div> with dblclick handler must have an ARIA role
43:     </form>
44: {:else}
45:     <div on:dblclick={edit}>
        ^
46:         {value}
47:     </div>

Can also be seen in last run of multibuild

Steps to reproduce

  1. In a clone of this repo.
  2. cd apps/admin/webapp/
  3. npm ci
  4. npm run build

Expected behavior

Build completes without warnings

@cpswan cpswan added the bug Something isn't working label Nov 19, 2024
@cpswan
Copy link
Member Author

cpswan commented Nov 26, 2024

@gkc somehow this got missed during planning. Are you able to take a look in this PR?

@gkc
Copy link
Contributor

gkc commented Nov 26, 2024

@gkc somehow this got missed during planning. Are you able to take a look in this PR?

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants