From d04951fdf34ea428a89a97c86244187fd0dc23de Mon Sep 17 00:00:00 2001 From: murali-shris Date: Mon, 11 Jul 2022 17:51:38 +0530 Subject: [PATCH 1/2] rename byPassCache to bypassCache --- at_commons/CHANGELOG.md | 2 ++ at_commons/lib/src/at_constants.dart | 2 +- at_commons/lib/src/verb/lookup_verb_builder.dart | 6 +++--- at_commons/lib/src/verb/plookup_verb_builder.dart | 6 +++--- at_commons/pubspec.yaml | 2 +- at_commons/test/lookup_verb_builder_test.dart | 2 +- at_commons/test/plookup_verb_builder_test.dart | 2 +- 7 files changed, 12 insertions(+), 10 deletions(-) diff --git a/at_commons/CHANGELOG.md b/at_commons/CHANGELOG.md index 4d5b1246..d4df0488 100644 --- a/at_commons/CHANGELOG.md +++ b/at_commons/CHANGELOG.md @@ -1,3 +1,5 @@ +## 3.0.19 +- Rename byPassCache to bypassCache in verb builder and at_constants ## 3.0.18 - Add 'showHidden' to scan regex to display hidden keys when set to true ## 3.0.17 diff --git a/at_commons/lib/src/at_constants.dart b/at_commons/lib/src/at_constants.dart index fb858407..c7b2f92c 100644 --- a/at_commons/lib/src/at_constants.dart +++ b/at_commons/lib/src/at_constants.dart @@ -65,5 +65,5 @@ const String commitLogCompactionKey = 'privatekey:commitLogCompactionStats'; const String accessLogCompactionKey = 'privatekey:accessLogCompactionStats'; const String notificationCompactionKey = 'privatekey:notificationCompactionStats'; -const String byPassCache = 'bypassCache'; +const String bypassCache = 'bypassCache'; const String showHidden = 'showhidden'; \ No newline at end of file diff --git a/at_commons/lib/src/verb/lookup_verb_builder.dart b/at_commons/lib/src/verb/lookup_verb_builder.dart index 538e0762..a0d6984e 100644 --- a/at_commons/lib/src/verb/lookup_verb_builder.dart +++ b/at_commons/lib/src/verb/lookup_verb_builder.dart @@ -27,13 +27,13 @@ class LookupVerbBuilder implements VerbBuilder { String? operation; // if set to true, returns the value of key on the remote server instead of the cached copy - bool byPassCache = false; + bool bypassCache = false; @override String buildCommand() { String command = 'lookup:'; - if (byPassCache == true) { - command += 'bypassCache:$byPassCache:'; + if (bypassCache == true) { + command += 'bypassCache:$bypassCache:'; } if (operation != null) { command += '$operation:'; diff --git a/at_commons/lib/src/verb/plookup_verb_builder.dart b/at_commons/lib/src/verb/plookup_verb_builder.dart index aee9f4d2..8f6692a2 100644 --- a/at_commons/lib/src/verb/plookup_verb_builder.dart +++ b/at_commons/lib/src/verb/plookup_verb_builder.dart @@ -18,13 +18,13 @@ class PLookupVerbBuilder implements VerbBuilder { String? operation; // if set to true, returns the value of key on the remote server instead of the cached copy - bool byPassCache = false; + bool bypassCache = false; @override String buildCommand() { String command = 'plookup:'; - if (byPassCache == true) { - command += 'bypassCache:$byPassCache:'; + if (bypassCache == true) { + command += 'bypassCache:$bypassCache:'; } if (operation != null) { command += '$operation:'; diff --git a/at_commons/pubspec.yaml b/at_commons/pubspec.yaml index 60afa87b..b3fd97af 100644 --- a/at_commons/pubspec.yaml +++ b/at_commons/pubspec.yaml @@ -1,6 +1,6 @@ name: at_commons description: A library of Dart and Flutter utility classes that are used across other components of the @‎platform. -version: 3.0.18 +version: 3.0.19 repository: https://github.com/atsign-foundation/at_tools homepage: https://atsign.dev diff --git a/at_commons/test/lookup_verb_builder_test.dart b/at_commons/test/lookup_verb_builder_test.dart index b85576dc..5d210cca 100644 --- a/at_commons/test/lookup_verb_builder_test.dart +++ b/at_commons/test/lookup_verb_builder_test.dart @@ -27,7 +27,7 @@ void main() { test('verify lookup bypass cache command', () { var lookupVerbBuilder = LookupVerbBuilder() - ..byPassCache = true + ..bypassCache = true ..atKey = 'email' ..sharedBy = 'alice'; expect(lookupVerbBuilder.buildCommand(), diff --git a/at_commons/test/plookup_verb_builder_test.dart b/at_commons/test/plookup_verb_builder_test.dart index 6d78e193..d3c2f82a 100644 --- a/at_commons/test/plookup_verb_builder_test.dart +++ b/at_commons/test/plookup_verb_builder_test.dart @@ -27,7 +27,7 @@ void main() { test('verify plookup bypass cache command', () { var plookupVerbBuilder = PLookupVerbBuilder() - ..byPassCache = true + ..bypassCache = true ..atKey = 'email' ..sharedBy = 'alice'; expect(plookupVerbBuilder.buildCommand(), From e3329a451987e1a82e3d81fe77caa203de9b21b5 Mon Sep 17 00:00:00 2001 From: murali-shris Date: Mon, 11 Jul 2022 17:59:06 +0530 Subject: [PATCH 2/2] dummy commit --- at_commons/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/at_commons/CHANGELOG.md b/at_commons/CHANGELOG.md index d4df0488..1053c340 100644 --- a/at_commons/CHANGELOG.md +++ b/at_commons/CHANGELOG.md @@ -1,5 +1,5 @@ ## 3.0.19 -- Rename byPassCache to bypassCache in verb builder and at_constants +- Rename byPassCache to bypassCache in lookup, plookup verb builders and at_constants ## 3.0.18 - Add 'showHidden' to scan regex to display hidden keys when set to true ## 3.0.17