Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uptake persistence refactoring in at_server #1810

Open
murali-shris opened this issue Feb 20, 2024 · 9 comments
Open

Uptake persistence refactoring in at_server #1810

murali-shris opened this issue Feb 20, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@murali-shris
Copy link
Member

Is your feature request related to a problem? Please describe.

Uptake the changes done in
#1788

Describe the solution you'd like

Replace calls to put/create with new params

Describe alternatives you've considered

No response

Additional context

No response

@murali-shris murali-shris added the enhancement New feature or request label Feb 20, 2024
@murali-shris murali-shris self-assigned this Feb 20, 2024
@murali-shris
Copy link
Member Author

Code changes done in
https://github.com/atsign-foundation/at_server/tree/uptake_persistence_refactoring
One of the tests related to setting metadata to null string (update_verb_test.dart) is failing. Investigating the issue.

@murali-shris
Copy link
Member Author

PRs raised and review done.
#1813
#1822
Will review adding more tests and merge the PRs once uptake on client side/app testing is done with new server changes

@murali-shris
Copy link
Member Author

blocked on failing end2end test in at_client
atsign-foundation/at_client_sdk#1255

@murali-shris
Copy link
Member Author

blocked on failing end2end test in at_client atsign-foundation/at_client_sdk#1255

Issue fixed
atsign-foundation/at_client_sdk#1275

@murali-shris
Copy link
Member Author

  • Resolved test failures, raised separate PRs for persistence and server
    Pending
  • test apps with server changes

@purnimavenkatasubbu
Copy link
Member

Test Scenarios Execution Report

Server-Side

  1. Created New Keys with Metadata:

    • Using the current branch of the server, I successfully created new keys and populated all available metadata fields.
  2. Updated Existing Key Metadata:

    • I modified the metadata of an existing key using the current branch of the server.
  3. Switched Branch and Verified Metadata:

    • I switched to the trunk branch of the server and utilized the same storage to verify the consistency of the metadata.
    • I again updated the existing metadata and confirmed that the changes were correctly reflected.
  4. Created Additional Keys with Metadata:

    • Using the trunk branch, I created new keys and populated them with metadata.

Client-Side

  1. Updated Keys with Trunk Branch:

    • Using the trunk branch of at_client, I updated several keys and verified the updates with the current trunk branch of the server.
  2. Cross-Branch Compatibility and Data Verification:

    • I switched to the current branch of the server and used the trunk branch of at_client with the same hive storage.
    • I confirmed that the existing data was accessible and verified that new data updates were correctly applied.

@murali-shris
Copy link
Member Author

Test Scenarios Execution Report

Server-Side

  1. Created New Keys with Metadata:

    • Using the current branch of the server, I successfully created new keys and populated all available metadata fields.
  2. Updated Existing Key Metadata:

    • I modified the metadata of an existing key using the current branch of the server.
  3. Switched Branch and Verified Metadata:

    • I switched to the trunk branch of the server and utilized the same storage to verify the consistency of the metadata.
    • I again updated the existing metadata and confirmed that the changes were correctly reflected.
  4. Created Additional Keys with Metadata:

    • Using the trunk branch, I created new keys and populated them with metadata.

Client-Side

  1. Updated Keys with Trunk Branch:

    • Using the trunk branch of at_client, I updated several keys and verified the updates with the current trunk branch of the server.
  2. Cross-Branch Compatibility and Data Verification:

    • I switched to the current branch of the server and used the trunk branch of at_client with the same hive storage.
    • I confirmed that the existing data was accessible and verified that new data updates were correctly applied.

@purnimavenkatasubbu Client side scenario 2. did you update existing metadata after upgrading to trunk branch ?
for both scenarios..did you check adding of new metadata and deletion of existing metadata?

@purnimavenkatasubbu
Copy link
Member

Test Scenarios Execution Report

Server-Side

  1. Created New Keys with Metadata:

    • Using the current branch of the server, I successfully created new keys and populated all available metadata fields.
  2. Updated Existing Key Metadata:

    • I modified the metadata of an existing key using the current branch of the server.
  3. Switched Branch and Verified Metadata:

    • I switched to the trunk branch of the server and utilized the same storage to verify the consistency of the metadata.
    • I again updated the existing metadata and confirmed that the changes were correctly reflected.
  4. Created Additional Keys with Metadata:

    • Using the trunk branch, I created new keys and populated them with metadata.

Client-Side

  1. Updated Keys with Trunk Branch:

    • Using the trunk branch of at_client, I updated several keys and verified the updates with the current trunk branch of the server.
  2. Cross-Branch Compatibility and Data Verification:

    • I switched to the current branch of the server and used the trunk branch of at_client with the same hive storage.
    • I confirmed that the existing data was accessible and verified that new data updates were correctly applied.

@purnimavenkatasubbu Client side scenario 2. did you update existing metadata after upgrading to trunk branch ? for both scenarios..did you check adding of new metadata and deletion of existing metadata?

Verified the following scenarios

  1. Updated existing metadata after upgrading to trunk , I was able to update the existing metadata successfully
  2. Deletion of existing metadata is not possible. We can only update the metadata.

For an existing metadata, Say existing ttr = 1000, Updated ttr =null. But it's still 1000 as its value.

@murali-shris
Copy link
Member Author

moving to backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants