Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification management #8

Open
3 of 5 tasks
realvarx opened this issue Jun 21, 2023 · 1 comment
Open
3 of 5 tasks

Add notification management #8

realvarx opened this issue Jun 21, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@realvarx
Copy link
Contributor

realvarx commented Jun 21, 2023

Is your feature request related to a problem? Please describe.

One crucial aspect in the development of the SDK is the integration of the notification functionality, encompassing the ability to send, receive, and monitor notifications. Prior to progressing with the porting of tools that rely on this feature, such as sshnp, it is highly recommended to prioritize the development of this functionality.

Describe the solution you'd like

Create Notification and NotificationService classes.

Original Dart/Java SDKs code references:

Task list (not necessarily complete or in the correct order):

(Steps inspired by @JeremyTubongbanua 's atsign-foundation/at_java#63 changelog)

  • Create AtNotification class
  • Expand Metadata class (new parameters)
  • Create NotifyVerbBuilder
  • Create NotificationService class, and get_notification_service method for AtClient
  • NotificationEnums
@realvarx realvarx added the enhancement New feature or request label Jun 21, 2023
@realvarx realvarx self-assigned this Jun 21, 2023
@realvarx realvarx mentioned this issue Jul 3, 2023
2 tasks
@realvarx
Copy link
Contributor Author

Just to keep the issue updated, notification management system was implemented in #21 and @Xlin123 added diverse features such as notify verb, more metadata parameters, iv and tests in #31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants